Ce site est optimisé pour être consulté depuis un navigateur moderne dans lequel JavaScript est activé.

Comment exécuter a github-actions step, even if the previous step fails, while still failing the job

ayi

I’m trying to follow an example Github has for testing my build with github actions, and then compressing the test results and uploading them as an artifact. 
<a href="https://help.github.com/en/actions/automating-your-workflow-with-github-actions/persisting-workflow-data-using-artifacts#uploading-build-and-test-artifacts" rel="noopener nofollow ugc">https://help.github.com/en/actions/automating-your-workflow-with-github-actions/persisting-workflow-data-using-artifacts#uploading-build-and-test-artifacts</a>
I’m having trouble with what to do when my tests fail though. This is my action. When my tests pass everything works great, my results are zipped an exported as an artifact, but if my tests fail, it stops the rest of the steps in the job, so my results never get published.
I tried adding the continue-on-error: true <a href="https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error" rel="noopener nofollow ugc">https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error</a>
This makes it continue after it fails and uploads my test results. but then the job is marked as passed, even though my test step failed. Is there some way to have it upload my artifact even if a step fails, while still marking the overall job as failed?
<pre><code class="lang-auto">name: CI
on:
pull_request:
branches:
- master
push:
branches:
- master

jobs:
build-and-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Test App
run: ./gradlew test

- name: Archive Rest Results
  uses: actions/upload-artifact@v1
  with:
    name: test-results
    path: app/build/reports/tests

</code></pre>

ayi_2

You can add
<pre><code class="lang-auto">if: always()

</code></pre>
to your step to have it run even if a previous step fails 
<a href="https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions">https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions</a>
so for a single step it would look like this:
<pre><code class="lang-auto">steps:

name: Build App
run: ./build.sh
name: Archive Test Results
if: always()
uses: actions/upload-artifact@v1
with:
name: test-results
path: app/build

</code></pre>
Or you can add it to a job:
<pre><code class="lang-auto">jobs:
job1:
job2:
needs: job1
job3:
if: always()
needs: [job1, job2]

</code></pre>
Additionally, as pointed out below, putting <code>always()</code> will cause the function to run even if the build is canceled. If you don’t want the function to run when you manually cancel a job, you can instead put:
<pre><code class="lang-auto">if: success() || failure()

</code></pre>
or
<pre><code class="lang-auto">if: '!cancelled()'

</code></pre>
(Quotes are needed so that <code>!cancelled()</code> is not interpreted as a YAML tag.)
Likewise, if you want to run a function ONLY when something has failed, you can put:
<pre><code class="lang-auto">if: failure()

</code></pre>
Also, as mentioned in the comments, if a status check function is not used in <code>if</code>, like
<pre><code class="lang-auto">if: true

</code></pre>
the result will (perhaps confusingly) behave like
<pre><code class="lang-auto">if: success() && true

</code></pre>
This is documented in <a href="https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions">Expressions - GitHub Docs</a>:
<h2><a name="p-25162-status-check-functions-1" class="anchor" href="#p-25162-status-check-functions-1" aria-label="Heading link"></a>Status check functions</h2>
You can use the following status check functions as expressions in if conditionals. A default status check of <code>success()</code> is applied unless you include one of these functions.